Install dependencies in setup with Homebrew#439
Merged
Conversation
mitchellhenke
approved these changes
Mar 13, 2024
mdiarra3
approved these changes
Mar 13, 2024
aduth
force-pushed
the
aduth-deps-homebrew
branch
from
1412bdb to
b17f56c
Compare
jc-gsa
approved these changes
Mar 13, 2024
Contributor
Author
|
Build failing due to expiring certificate, not harmful. See #435 (comment) . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This adds a Brewfile listing required dependencies and calls it as part of the
bin/setup(make setup) task, similar to what we do in the IdP.This should make the setup process easier and avoid issues where the developer may not have the required dependencies installed. I encountered this myself when seeing nginx errors, not realizing that nginx was a dependency because it wasn't listed as one, and was only referenced as a requirement later in the README.
This removes quite a bit of detail from the README, with the hoped expectation these are accounted for in
make setup, and wanting to keep the instructions simple and direct. Alternatively, we could add some of this detail back in other sections of the README if needed.📜 Testing Plan
Run
make setupIdeally you'd be starting fresh and can confirm that you can follow the instructions successfully to a running application.