Skip to content

Use client_id in logout request#120

Merged
aduth merged 2 commits intomainfrom
aduth-logout-client-id
Sep 30, 2022
Merged

Use client_id in logout request#120
aduth merged 2 commits intomainfrom
aduth-logout-client-id

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Sep 28, 2022

Pairs with (blocked by) 18F/identity-idp#7017 (I put together these changes to test that pull request, figured I may as well make a pull request)

@aduth aduth requested a review from mitchellhenke September 28, 2022 17:44
Copy link

@mitchellhenke mitchellhenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@aduth
Copy link
Contributor Author

aduth commented Sep 29, 2022

@mitchellhenke Do you have a sense when these changes will be safe to merge? Is the feature flag that's checked in 18F/identity-idp#7017 already available in all the environments we're deploying this sample app?

@mitchellhenke
Copy link

@mitchellhenke Do you have a sense when these changes will be safe to merge? Is the feature flag that's checked in 18F/identity-idp#7017 already available in all the environments we're deploying this sample app?

It should be enabled in production today, and I opened 18F/identity-idp#7052 to enable it everywhere else too.

@aduth
Copy link
Contributor Author

aduth commented Sep 29, 2022

It should be enabled in production today, and I opened 18F/identity-idp#7052 to enable it everywhere else too.

Ok I'll plan to wait 'til that pull request is merged, so that it doesn't cause issues for local development.

@mitchellhenke
Copy link

This is good to go

@aduth aduth merged commit b38d309 into main Sep 30, 2022
@aduth aduth deleted the aduth-logout-client-id branch September 30, 2022 14:41
@timothy-spencer timothy-spencer restored the aduth-logout-client-id branch June 6, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants