Skip to content
This repository was archived by the owner on Jun 12, 2021. It is now read-only.

Log when we send dob_year_only#21

Merged
zachmargolis merged 1 commit intomainfrom
margolis-log-dob-year-only
Feb 3, 2021
Merged

Log when we send dob_year_only#21
zachmargolis merged 1 commit intomainfrom
margolis-log-dob-year-only

Conversation

@zachmargolis
Copy link
Copy Markdown
Contributor

Feedback from LN was that we were sending the whole DOB, this logging will tell me if the correct branch is being hit

I thought maybe about logging the payload, since it's "just" the year of birth, but that seemed risky

Next steps:

  • Merge this
  • Update IDP to point at this version, deploy that to staging and test again

Copy link
Copy Markdown
Contributor

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachmargolis zachmargolis merged commit dd16ec9 into main Feb 3, 2021
zachmargolis added a commit that referenced this pull request Feb 18, 2021
zachmargolis added a commit that referenced this pull request Feb 18, 2021
* Revert "Log when we send dob_year_only (#21)"

This reverts commit dd16ec9.

* Revert "Optionally only send year of birth for check (LG-3706) (#20)"

This reverts commit e9a1650.

* Update version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants