Jmax/lg 12239 Pii re-encryption edge case#9995
Merged
Conversation
changelog: Bug Fixes,PII re-encryption,fix edge-case bug.
matthinz
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12239
🛠 Summary of changes
Via CloudWatch monitoring, we determined that we had an edge case in our PII re-encryption code which caused us to occasionally fail when re-encrypting PII for a pending profile. We modified the code to re-encrypt pending profile's PII if present, and deactivate the profile if there is no associated PII.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
spec/services/user_profiles_encryptor_spec.rb:66passes without error