Read vtr property while reading and writing ServiceProviderRequest#9993
Merged
Read vtr property while reading and writing ServiceProviderRequest#9993
vtr property while reading and writing ServiceProviderRequest#9993Conversation
zachmargolis
approved these changes
Jan 29, 2024
jmhooper
force-pushed
the
jmhooper-write-vtr-to-sp-request
branch
from
007e827 to
6f96e22
Compare
Base automatically changed from
jmhooper-add-vtr-to-service-provider-request
to
main
January 29, 2024 20:29
jmhooper
force-pushed
the
jmhooper-write-vtr-to-sp-request
branch
2 times, most recently
from
3b747cb to
a00798f
Compare
In #9991 the `vtr` property is added to the `ServiceProviderRequest`. Since the `vtr` property is introduced there it is unsafe to create a `ServiceProviderRequest` record with `vtr` during a deploy since some instances may have code that is unaware of the `vtr` property and will result in an `ArgumentError` when creating a `ServiceProviderRequest` Once the changes in #9991 are deployed it should be safe to create records with the `vtr` property. This commit does that in the `ServiceProviderRequestProxy`. [skip changelog]
jmhooper
force-pushed
the
jmhooper-write-vtr-to-sp-request
branch
from
a00798f to
e03acc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #9991 the
vtrproperty is added to theServiceProviderRequest. Since thevtrproperty is introduced there it is unsafe to create aServiceProviderRequestrecord withvtrduring a deploy since some instances may have code that is unaware of thevtrproperty and will result in anArgumentErrorwhen creating aServiceProviderRequestOnce the changes in #9991 are deployed it should be safe to create records with the
vtrproperty. This commit does that in theServiceProviderRequestProxy.This should not be merged until the changes in #9991 are merged and deployed all the way through production.