Skip to content

Add the requested vectors of trust to ServiceProviderRequest #9991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 3 commits into from
Jan 29, 2024
Merged

Add the requested vectors of trust to ServiceProviderRequest #9991

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b049adb
Add the requested vectors of trust to `ServiceProviderRequest`
jmhooper Jan 29, 2024
47fbcee
include acr_vlues
jmhooper Jan 29, 2024
4ae61e6
same as before but without syntax errors
jmhooper Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/models/service_provider_request.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ def initialize(
ial: nil,
aal: nil,
requested_attributes: [],
biometric_comparison_required: false
biometric_comparison_required: false,
acr_values: nil, # rubocop:disable Lint/UnusedMethodArgument
vtr: nil # rubocop:disable Lint/UnusedMethodArgument
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add acr too? so we dont have to persisnt ial//aal separately?

Suggested change
vtr: nil # rubocop:disable Lint/UnusedMethodArgument
vtr: nil, # rubocop:disable Lint/UnusedMethodArgument
acr: nil # rubocop:disable Lint/UnusedMethodArgument

Copy link
Copy Markdown
Contributor Author

@jmhooper jmhooper Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have wavered on whether we should add ACR separately. They get split out and parsed separately by both the OIDC controller and the SAML request.

I was imagining something like this (at least for now):

class ServiceProviderRequest
  def acr_values
    [ial, aal].join(' ')
  end
end

Eventually we may get to a place where we can pass in a raw ACR value. I'm not sure whether that is better to go for now or hold off on. I haven't spent enough time hacking on either the SAML or OIDC portion to know which is better.

Copy link
Copy Markdown
Contributor Author

@jmhooper jmhooper Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I did some poking around and decided to go ahead and throw the raw "acr_values" prop on there

)
@uuid = uuid
@issuer = issuer
Expand Down