Allow resending OTP in reauthentication context#998
Merged
Conversation
**Why**: It would be broken functionality otherwise. **How**: Define a new context called `reauthentication` in the change factor flow because `TwoFactorAuthenticable#check_already_authenticated` should only be called in the initial authentication context.
zachmargolis
approved these changes
Jan 26, 2017
|
|
||
| def authentication_context? | ||
| context == 'authentication' | ||
| context == 'authentication' || context == 'reauthentication' |
Contributor
There was a problem hiding this comment.
maybe now is still not the time...but I think it would be great if we could make these auth contexts into constants? Making them constants helps remind that they're finite and enumerable
Contributor
Author
There was a problem hiding this comment.
agreed. I was planning on making another pass at this module to see how to improve it.
amoose
pushed a commit
that referenced
this pull request
Mar 7, 2017
**Why**: It would be broken functionality otherwise. **How**: Define a new context called `reauthentication` in the change factor flow because `TwoFactorAuthenticable#check_already_authenticated` should only be called in the initial authentication context.
amoose
pushed a commit
that referenced
this pull request
Mar 8, 2017
**Why**: It would be broken functionality otherwise. **How**: Define a new context called `reauthentication` in the change factor flow because `TwoFactorAuthenticable#check_already_authenticated` should only be called in the initial authentication context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: It would be broken functionality otherwise.
How: Define a new context called
reauthenticationin the changefactor flow because
TwoFactorAuthenticable#check_already_authenticatedshould only be called in the initial authentication context.