Skip to content

LG-12027: Normalize whitespace in PII #9972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthinz merged 3 commits into from
Jan 25, 2024
Merged

LG-12027: Normalize whitespace in PII #9972

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4943083
Normalize whitespace in Pii::Attributes values
matthinz Jan 24, 2024
0367b02
Handle when we set a PII attribute to a non-string
matthinz Jan 25, 2024
8e69ef8
Remove extraneous '&'
matthinz Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/services/pii/attributes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def self.new_from_hash(hash)
attrs = new
hash.with_indifferent_access.
slice(*members).
each { |key, val| attrs[key] = val }
each { |key, val| attrs[key] = val.is_a?(String) ? val&.squish : val }
Comment thread
matthinz marked this conversation as resolved.
Outdated
attrs
end

Expand Down
22 changes: 22 additions & 0 deletions spec/services/pii/attributes_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,28 @@
expect(pii.identity_doc_zipcode).to eq('20005')
expect(pii.identity_doc_address_state).to eq('NY')
end

it 'normalizes whitespace in values' do
pii = described_class.new_from_hash(
identity_doc_address1: " 1600\r\r Pennsylvania Avenue\t",
identity_doc_address2: ' Apt 2 ',
identity_doc_city: ' Washington ',
state_id_jurisdiction: ' DC ',
identity_doc_zipcode: ' 20005 ',
identity_doc_address_state: ' NY ',
)
expect(pii.identity_doc_address1).to eq('1600 Pennsylvania Avenue')
expect(pii.identity_doc_address2).to eq('Apt 2')
expect(pii.identity_doc_city).to eq('Washington')
expect(pii.state_id_jurisdiction).to eq('DC')
expect(pii.identity_doc_zipcode).to eq('20005')
expect(pii.identity_doc_address_state).to eq('NY')
end

it 'accepts Date values' do
pii = described_class.new_from_hash(dob: Date.new(2000, 1, 2))
expect(pii.dob).to eql(Date.new(2000, 1, 2))
end
end

describe '#new_from_json' do
Expand Down