Skip to content

Mattw/bold lint errors #9968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n1zyy merged 6 commits into from
Jan 25, 2024
Merged

Mattw/bold lint errors #9968

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ad62bcd
Bolds non-ruby linter output
n1zyy Jan 24, 2024
d1a4feb
Adds out-of-order method for demo
n1zyy Jan 24, 2024
70e927d
De-alphabetize methods to trigger error
n1zyy Jan 24, 2024
da3e603
Remove -e flag
n1zyy Jan 24, 2024
d326165
Removes intentional error to trigger linter for demo
n1zyy Jan 25, 2024
f8add0d
Merge branch 'main' into mattw/bold-lint-errors
n1zyy Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ lint_analytics_events: .yardoc ## Checks that all methods on AnalyticsEvents are

lint_analytics_events_sorted:
@test "$(shell grep '^ def ' app/services/analytics_events.rb)" = "$(shell grep '^ def ' app/services/analytics_events.rb | sort)" \
|| (echo 'Error: methods in analytics_events.rb are not sorted alphabetically' && exit 1)
|| (echo '\033[1;31mError: methods in analytics_events.rb are not sorted alphabetically\033[0m' && exit 1)

lint_tracker_events: .yardoc ## Checks that all methods on AnalyticsEvents are documented
bundle exec ruby lib/analytics_events_documenter.rb --class-name="IrsAttemptsApi::TrackerEvents" --check --skip-extra-params $<
Expand Down