Merged
Conversation
changelog: Internal, Build Tools, Improve performance of stylesheet build tool
zachmargolis
approved these changes
Jan 22, 2024
Contributor
Author
|
I can't recall if I had specifically dug into the performance characteristics of the synchronous vs. asynchronous compilers, but a brief test with |
Contributor
Author
|
Switched to async compiler in 3fe4d75 and updated performance result in original comment. |
zachmargolis
approved these changes
Jan 22, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Enhances the
@18f/identity-build-sassSass compilation tool to use the new Shared Resources API added to Sass in a recent version. This feature is well-suited for our use-case, where we compile many different stylesheets, and each stylesheet shares a number of common resources (USWDS, etc.).Performance:
Average of
yarn build:csson a set of 10 runs:Before: 8.75s
After:
6.71s2.98s after 3fe4d75Diff:
-2.04s (-23.3%)-5.77s (-65.9%) after 3fe4d75📜 Testing Plan
Verify that
yarn build:csssuccessfully outputs toapp/assets/build