Skip to content

LG-12140 Fix Reuse Rates Unit Test failure #9933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThatSpaceGuy merged 1 commit into from
Jan 17, 2024
Merged

LG-12140 Fix Reuse Rates Unit Test failure #9933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions spec/factories/users.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
confirmed_at { Time.zone.now }
confirmation_token { nil }
confirmation_sent_at { 5.minutes.ago }
registered_at { Time.zone.now }
end

created_at { Time.zone.now }
Expand Down Expand Up @@ -179,8 +180,8 @@
trait :fully_registered do
with_phone

after :create do |user|
user.create_registration_log(registered_at: Time.zone.now)
after :create do |user, evaluator|
user.create_registration_log(registered_at: evaluator.registered_at)
end
end

Expand Down
27 changes: 15 additions & 12 deletions spec/services/reporting/account_reuse_report_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,6 @@
let(:sp_c) { 'c' }
let(:sp_d) { 'd' }

def create_identity(user_id:, created_at:, provider:, verified_at:)
ServiceProviderIdentity.create(
user_id: user_id, service_provider: provider,
created_at: created_at,
last_ial2_authenticated_at: in_query, verified_at: verified_at
)
end

before do
create(
:service_provider,
Expand Down Expand Up @@ -136,10 +128,11 @@ def create_identity(user_id:, created_at:, provider:, verified_at:)

users_to_query.each do |user|
user[:sp].each_with_index do |sp, i|
create_identity(
ServiceProviderIdentity.create(
user_id: user[:id],
service_provider: sp,
created_at: user[:created_timestamp],
provider: sp,
last_ial2_authenticated_at: in_query,
verified_at: user[:sp_timestamp][i],
)
end
Expand All @@ -148,10 +141,20 @@ def create_identity(user_id:, created_at:, provider:, verified_at:)
# Create active profiles for total_proofed_identities
# These 13 profiles will yield 10 active profiles in the results
(1..10).each do |_|
create(:profile, :active, activated_at: in_query)
create(
:profile,
:active,
activated_at: in_query,
user: create(:user, :fully_registered, registered_at: in_query),
)
end
(1..3).each do |_|
create(:profile, :active, activated_at: out_of_query)
create(
:profile,
:active,
activated_at: out_of_query,
user: create(:user, :fully_registered, registered_at: in_query),
)
end
end

Expand Down