Remove echo command in image build that invalidates caching for all following layers#9932
Merged
mitchellhenke merged 3 commits intomainfrom Jan 22, 2024
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/remove-echo-in-docker-build-for-better-caching
branch
from
90af04c to
1520c73
Compare
zachmargolis
approved these changes
Jan 17, 2024
mitchellhenke
force-pushed
the
mitchellhenke/remove-echo-in-docker-build-for-better-caching
branch
2 times, most recently
from
7f581a7 to
3506130
Compare
added 3 commits
January 22, 2024 12:08
changelog: Internal, Containerization, Refactor review app dockerfile to improve cachability
mitchellhenke
force-pushed
the
mitchellhenke/remove-echo-in-docker-build-for-better-caching
branch
from
3506130 to
b67089d
Compare
mitchellhenke
deleted the
mitchellhenke/remove-echo-in-docker-build-for-better-caching
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Noticed while reviewing the build process of review app images that this debugging echo invalidates all caching after it. Many layers here should be cacheable, so this should speed up review app image building.