LG-12018: Refactor account deletion/message to be variable

[jmdembe]

🎫 Ticket

LG-12018: Refactor account deletion/message to be variable

🛠 Summary of changes

This PR supports future efforts where the waiting period of a deletion account can be a variable.

📜 Testing Plan

N/A because this is an internal change

[aduth]

Account reset should use the period from IdentityStore.config.account_reset_wait_period_days, not Devise.confirm_within?

[jmdembe]

The way I understood this, this should use account_reset_wait_period_days because this is for after the account reset is sent which could vary based on what the user sets.

[aduth]

These changes look good to me.

I noticed there is one more instance of "24 hours" that we need to replace for this ticket. I'll leave it to you if you want to handle that here, or merge this as-is and create a follow-on pull request.

identity-idp/config/locales/account_reset/en.yml

Lines 33 to 34 in 21d5b41

	confirm: If you cancel now, you must create a new request and wait another 24
	hours to delete your account.

[aduth]

One other nice effect of this that occurs to me is that this would have been untranslated content, which is now fixed.

You can see "24 hours" in the Spanish version of the current template, for example.

[jmdembe]

I noticed there is one more instance of "24 hours" that we need to replace for this ticket. I'll leave it to you if you want to handle that here, or merge this as-is and create a follow-on pull request.

I'll handle that change here. I do not see a reason why it should be a separate ticket.

[aduth]

I'll handle that change here. I do not see a reason why it should be a separate ticket.

That's fine. I wasn't suggesting another ticket though, just another pull request if it'd be easier to separate the code changes that way.

[jmdembe]

I'll handle that change here. I do not see a reason why it should be a separate ticket.

That's fine. I wasn't suggesting another ticket though, just another pull request if it'd be easier to separate the code changes that way.

🤦🏾‍♀️ I read "pull request" as "ticket."