Skip to content

Fix Accessibility Violation - Header level #9918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gina-yamada merged 5 commits into from
Jan 12, 2024
Merged

Fix Accessibility Violation - Header level #9918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa76480
Fix accessibilty violation - header level
soniaconnolly Jan 12, 2024
4e490fd
add h2 selector to pick up style
gina-yamada Jan 12, 2024
fde09ba
changelog: Upcoming Features, In-person proofing, Fix accessibility v…
gina-yamada Jan 12, 2024
8a931f2
fix linter err
gina-yamada Jan 12, 2024
5298a71
add regression test for accessibility
gina-yamada Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/assets/stylesheets/components/_radio-button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
}

.usa-radio__label--text {
h2,
h3 {
@include u-text('gray-70');
}
Expand Down
2 changes: 1 addition & 1 deletion app/views/idv/how_to_verify/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<span class="usa-tag usa-tag--informative">
<%= t('doc_auth.tips.most_common') %>
</span>
<h3><%= t('doc_auth.headings.verify_online') %></h3>
<h2 class="h3"><%= t('doc_auth.headings.verify_online') %></h2>
<span class="usa-radio__label-description">
<p><%= t('doc_auth.info.verify_online_instruction') %></p>
<p><%= t('doc_auth.info.verify_online_description') %></p>
Expand Down
13 changes: 13 additions & 0 deletions spec/features/accessibility/idv_pages_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,19 @@
expect_page_to_have_no_accessibility_violations(page)
end

scenario 'how to verify page' do
allow(IdentityConfig.store).to receive(:in_person_proofing_enabled).and_return(true)
allow(IdentityConfig.store).to receive(:in_person_proofing_opt_in_enabled).and_return(true)
sign_in_and_2fa_user

visit idv_welcome_url
complete_welcome_step
complete_agreement_step

expect(current_path).to eq idv_how_to_verify_path
expect_page_to_have_no_accessibility_violations(page)
end

scenario 'cancel idv' do
sign_in_and_2fa_user

Expand Down