Skip to content

Updates language#989

Merged
el-mapache merged 1 commit intomasterfrom
ab-update-pkey-language
Jan 25, 2017
Merged

Updates language#989
el-mapache merged 1 commit intomasterfrom
ab-update-pkey-language

Conversation

@el-mapache
Copy link
Copy Markdown
Contributor

@el-mapache el-mapache commented Jan 25, 2017

Why: To reflect current designs

Screenshot!

screen shot 2017-01-25 at 1 59 00 pm

@el-mapache el-mapache self-assigned this Jan 25, 2017
@el-mapache el-mapache requested review from andrewhughey and hursey013 and removed request for andrewhughey January 25, 2017 19:54
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we update this outer container to a px4 and remove the ml2 on the container around the words the left and right edges of the content will mimic ryan's design a little closer.

**Why**: To reflect current designs
@el-mapache el-mapache force-pushed the ab-update-pkey-language branch from 08048e1 to 8b36a85 Compare January 25, 2017 21:58
@el-mapache
Copy link
Copy Markdown
Contributor Author

thanks @hursey013 , edited

Copy link
Copy Markdown
Contributor

@hursey013 hursey013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@el-mapache el-mapache merged commit 80b9b96 into master Jan 25, 2017
@el-mapache el-mapache deleted the ab-update-pkey-language branch January 25, 2017 22:22
amoose pushed a commit that referenced this pull request Mar 7, 2017
**Why**: To reflect current designs
amoose pushed a commit that referenced this pull request Mar 8, 2017
**Why**: To reflect current designs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants