Conversation
**Why**: Add fieldset and legend for accessibility. Also small bug fix that reflects the correct yes/no output for the checkbox questions. Currently they are always being displayed as Yes no matter if they are checked or not.
Contributor
|
Is there a GH issue for this or is it just something you noticed? |
Contributor
Author
|
@jessieay just linked to the a11y issue which relates to the checkboxes and discovered the other small issue when implementing that. I can separate them into different PRs if need be. |
jessieay
approved these changes
Jan 25, 2017
Contributor
jessieay
left a comment
jessieay
left a comment
There was a problem hiding this comment.
Looks good to me!
Changes mentioned in the PR description seem a bit separate from the accessibility concerns in the related GH issue. But this addresses both, right?
Contributor
Author
|
Yeah, this is primarily for https://github.com/18F/identity-private/issues/1361, however I tacked on fixing the checkbox values as well. I'll separate them out into their own PRs next time. |
amoose
pushed a commit
that referenced
this pull request
Mar 7, 2017
**Why**: Add fieldset and legend for accessibility. Also small bug fix that reflects the correct yes/no output for the checkbox questions. Currently they are always being displayed as Yes no matter if they are checked or not.
amoose
pushed a commit
that referenced
this pull request
Mar 8, 2017
**Why**: Add fieldset and legend for accessibility. Also small bug fix that reflects the correct yes/no output for the checkbox questions. Currently they are always being displayed as Yes no matter if they are checked or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Add fieldset and legend for accessibility.
Also small bug fix that reflects the correct yes/no output for the checkbox questions. Currently they are always being displayed as "Yes" in the generated email no matter if they are checked or not.