Create tmp/pids directory for puma#9878
Merged
stephencshelton merged 1 commit intomainfrom Jan 8, 2024
Merged
Conversation
mitchellhenke
approved these changes
Jan 8, 2024
stephencshelton
force-pushed
the
sshelton/update-review-app
branch
from
16076a6 to
c57cf18
Compare
stephencshelton
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
At the moment review apps are failing to write the pid to
tmp/pidsbecause that directory is not created as part of the docker image build. This creates thattmp/pidsdirectory which allows the puma process to launch again.