LG-11917: Update doc to use new version for all client in staging.#9875
Merged
dawei-nava merged 4 commits intomainfrom Jan 24, 2024
Merged
LG-11917: Update doc to use new version for all client in staging.#9875dawei-nava merged 4 commits intomainfrom
dawei-nava merged 4 commits intomainfrom
Conversation
aduth
reviewed
Jan 8, 2024
night-jellyfish
approved these changes
Jan 9, 2024
Contributor
night-jellyfish
left a comment
night-jellyfish
left a comment
There was a problem hiding this comment.
Thank you for updating the documentation!
eileen-nava
reviewed
Jan 9, 2024
Contributor
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
I think it would be helpful to somewhere plainly state that when testing in staging, traffic to the new version should be at 100%. Maybe mention that on line 59?
eileen-nava
approved these changes
Jan 24, 2024
Contributor
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
LGTM, thanks for updating documentation.
docs/sdk-upgrade.md
Outdated
docs/sdk-upgrade.md
Outdated
Contributor
There was a problem hiding this comment.
Good call-out here. 👏🏻
kellular
approved these changes
Jan 24, 2024
kellular
left a comment
kellular
left a comment
There was a problem hiding this comment.
LGTM! thank you for adding the manual testing instrustions.
changelog: Internal, Documentation, Use new SDK for all clients in staging.
dawei-nava
force-pushed
the
dwang/LG-11917-sdk-stg-test
branch
from
4cd0329 to
cee2489
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-11917
🛠 Summary of changes
Update document.