Remove browser_log: true from analytics_spec#9874
Merged
soniaconnolly merged 1 commit intomainfrom Jan 8, 2024
Merged
Conversation
[skip changelog]
aduth
approved these changes
Jan 8, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM 👍
There was a build failure, but it looked to be unrelated, so I restarted the build and hopefully it passes this time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
I was getting a local chromedriver error that went away when I added
allow_browser_log: trueto specs. Now fixed locally, and should not have been checked in, so removing that.For some reason feature specs for the in person flow do need
allow_browser_log: trueto pass. Do we know why that is?📜 Testing Plan
Specs pass on CI.