LG-11698 Write that selfie check was performed in user's profile#9858
Merged
LG-11698 Write that selfie check was performed in user's profile#9858
Conversation
changelog: Internal, IdV, save selfie status to user profile Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
app/services/idv/profile_maker.rb
Outdated
| def set_idv_level(in_person_verification_needed:, selfie_check_performed:) | ||
| if in_person_verification_needed | ||
| :legacy_in_person | ||
| elsif selfie_check_enabled && selfie_check_performed |
Contributor
There was a problem hiding this comment.
Can we use the new FeatureManagement method here instead of creating a new one for selfie_check_enabled?
Suggested change
| elsif selfie_check_enabled && selfie_check_performed | |
| elsif !FeatureManagement.idv_block_biometrics_requests? && selfie_check_performed |
| allow(load_result).to receive(:attention_with_barcode?).and_return(false) | ||
|
|
||
| allow(load_result).to receive(:success?).and_return(load_result_success) | ||
| allow(load_result).to receive(:selfie_check_performed).and_return(selfie_check_performed) |
Contributor
There was a problem hiding this comment.
Recommend returning false in this mock, and then you don't need the let that was added above.
Suggested change
| allow(load_result).to receive(:selfie_check_performed).and_return(selfie_check_performed) | |
| allow(load_result).to receive(:selfie_check_performed).and_return(false) |
soniaconnolly
approved these changes
Jan 5, 2024
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM! Tested locally and with Alex, works as expected.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11698
🛠 Summary of changes
We added the ability to write if a selfie check was performed to profiles to determine if they have proofed with a selfie.
📜 Testing Plan
doc_auth_selfie_capture_enabled: trueu = User.find_with_email("EMAIL")u.profiles.first.idv_level="unsupervised_with_selfie"