Merged
Conversation
* Add validation to GpoConfirmation model Validate that: - entry is present - entry contains all required fields - entry contains a valid zipcode * Ensure we throw a 500 in EnterPasswordController Since enforcement is with rails validation, this would be a 4XX error by default. Wrapping it in another error ensures it'll get passed back to the user as a 500 * Don't allow GpoConfirmationMaker to accept nil zipcode * Fix GpoMail spec Ensure we're passing now-required fields in. * Update GpoConfirmationMaker spec to use more examples * Don't mint a profile when GpoConfirmation write fails If we mint the profile, the user will see the "your letter is on the way" screen when they refresh. * Validate individual attributes Introduce phantom attributes on GpoConfirmation that we can validate with traditional means This should allow better error messages for logging purposes * Destroy IdV session on invalid gpo data Ideally we'd show an error and have the user confirm their address, but as a stopgap we can destroy the idv session and force the user to restart. * changelog: Bug Fixes, Identity verification, Prevent telling the user their letter is on the way if it actually isn't * Move zip code normalization into GpoConfirmation It will normalize its own zip code values. (This lets zip validation just piggy back on zip normalization) * Watch for invalid GPO confirmations when uploading - Validate confirmations before sending to GPO - Notify NewRelic if there are invalid confirmations present * Add invalid_gpo_confirmation_zipcode config Allow configuring a certain zipcode to cause GPO confirmation validation to blow up * Don't bother killing IdvSession on error I think the session is not committed due to the 500 error, so we need to take a different path that doesn't depend on saving state in session * Don't use method_missing * Add a couple more zip code examples
changelog: Internal, Scripts, Add addtional bounce information to email-deliveries script
[skip changelog] We always find ourselves copy and pasting the same JIRA link for the relevant ticket. Adding this to the PR template allows us to just replace the X's with the ticket number.
* Replace hasOwn with Object.hasOwn Ref: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwn changelog: Internal, Code Quality, Replace custom utilities with native equivalents * Replace fromPairs with Object.fromEntries Ref: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/fromEntries changelog: Internal, Code Quality, Replace custom utilities with native equivalents
changelog: Internal, Code Quality, Remove unused code
changelog: Internal, Code Quality, Remove unused code
matthinz
approved these changes
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
Internal