Remove Double Address Verification from jobs - Deploy First

[JackRyan1989]

🎫 Ticket

🛠 Summary of changes

This PR compliments #9829.

The changes here should address steps 1 & 2 when removing a value from jobs:

Deploy 1: Remove all uses of the argument within the job, and add a default value
Deploy 2: Remove the argument in calls to the job (can be combined with the first deploy if there was already a default value)

https://handbook.login.gov/articles/manage-50-50-state.html#remove-an-argument-from-a-job-perform-method

📜 Testing Plan

Tests are already aware of the ipp_enrollment_in_progress variable, so no changes to tests are required. All should pass.

[svalexander]

is the linter requiring this b/c the default value of ipp_enrollment_in_progress is now true?

[JackRyan1989]

Actually no. It's required because we're passing in double_address_verification as an argument, but not using that value in the method.

[svalexander]

ahh ok thank you for clarifying that!

[aduth]

The changes here should address steps 1 & 2 when removing a value from jobs:

If Steps 1 and 2 are meant to be separate deploys, should the changes here include both, or should they be split across two pull requests?

[JackRyan1989]

The changes here should address steps 1 & 2 when removing a value from jobs:
If Steps 1 and 2 are meant to be separate deploys, should the changes here include both, or should they be split across two pull requests?

Good q! My read of the text in the parens in the handbook:

(can be combined with the first deploy if there was already a default value)

is that since I have a default value set for double_address_verification in resolution_proofing_job, we can combine 1 and 2. Let me know if you think my read is incorrect or if I'm not adequately setting a default value. @aduth

[aduth]

Ah! I missed the parenthesized text. In that case, I think it should be okay 👍

[svalexander]

LGTM