Merged
Conversation
dawei-nava
requested review from
amirbey,
charleyf,
eileen-nava and
night-jellyfish
charleyf
reviewed
Jan 4, 2024
changelog: User-facing Improvement, Doc Auth, Upgrade Acuant SDK to 11.9.2
dawei-nava
force-pushed
the
dwang/LG-11916-sdk-upgrade
branch
from
6907e9e to
ef5dab6
Compare
charleyf
approved these changes
Jan 4, 2024
Contributor
charleyf
left a comment
charleyf
left a comment
There was a problem hiding this comment.
✅ I'm approving this, but we should not merge until someone tests with Android.
Testing note: Developer's will need to add these lines to their local config "application.yml" to test this, otherwise you'll be using 11.9.1 not the version we want to test (11.9.2):
# Add to application.yml
idv_acuant_sdk_version_default: '11.9.2'
idv_acuant_sdk_version_alternate: '11.9.2'
Also, when testing, make sure to check that the sources are in fact getting loaded from the 11.9.2 directory. To do that you'll need to use Safari on your computer per the mobile debugging guide.
I tested this PR on my phone (iPhone 13 Pro, iOS 17.2.1) in Chrome and Safari and the Acuant SDK works as expected. I checked:
- ID capture (front and back) still works
- Uploading photos works.
- Uploading a file works
- Error page still works (used image resolution yaml file)
Contributor
Author
|
@amirbey did test on Android phone. |
amirbey
approved these changes
Jan 4, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11916
🛠 Summary of changes
Include Acuant SDK 11.9.2