Reimplement password strength as ViewComponent, custom element#9826
Merged
Reimplement password strength as ViewComponent, custom element#9826
Conversation
app/javascript/packages/password-strength/password-strength-element.ts
Outdated
Show resolved
Hide resolved
app/javascript/packages/password-strength/password-strength-element.ts
Outdated
Show resolved
Hide resolved
1b11d1b to
7093eb0
Compare
zachmargolis
approved these changes
Jan 5, 2024
app/javascript/packages/password-strength/password-strength-element.ts
Outdated
Show resolved
Hide resolved
5baa02b to
059d51b
Compare
3a6c8c3 to
62e1b17
Compare
Contributor
Author
|
Okay, this should be essentially complete now. At this point, I might just wait for the content freeze to lapse to merge, despite not really making any meaningful content changes. |
changelog: Internal, Code Quality, Improve maintainability of password strength UI element
Avoid mappings See: #9826 (comment)
We've since moved away from vendor which received string content as XML Originally: #1531
Easier comparison See: https://github.com/18F/identity-idp/pull/9826/files#r1443220055 Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
62e1b17 to
247a7cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Refactors password strength UI element as a combination ViewComponent component + JavaScript custom element.
As part of this work, removes ad-hoc text size reduction previously applied to strength and feedback elements.
The refactoring adopts frontend architecture conventions, namely:
Related: #9811
Why?
📜 Testing Plan
Verify there are no regressions in the behavior of password strength:
👀 Screenshots