-
Notifications
You must be signed in to change notification settings - Fork 166
Jmax/lg 11942 add a selfie check performed prop to the doc auth response #9825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b2ec9d8
61e6b73
f35260d
e0c09af
52847c4
2578b29
745424c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,7 @@ | |
| let(:exception) { nil } | ||
| let(:pii_from_doc) { {} } | ||
| let(:attention_with_barcode) { false } | ||
|
|
||
| subject(:response) do | ||
| described_class.new( | ||
| success: success, | ||
|
|
@@ -22,6 +23,7 @@ | |
| let(:other_exception) { nil } | ||
| let(:other_pii_from_doc) { {} } | ||
| let(:other_attention_with_barcode) { false } | ||
|
|
||
| let(:other) do | ||
| described_class.new( | ||
| success: other_success, | ||
|
|
@@ -156,4 +158,31 @@ | |
| expect(response.doc_type_supported?).to eq(true) | ||
| end | ||
| end | ||
|
|
||
| # LG-11942 | ||
| # The following is for the stubbed selfie check value. Replace with | ||
| # the real tests when selfie implementation gets to that point. | ||
| describe 'selfie_check_performed?' do | ||
| before do | ||
| allow(IdentityConfig.store). | ||
| to receive(:doc_auth_selfie_capture_enabled). | ||
| and_return(selfies_enabled) | ||
|
Comment on lines
+167
to
+169
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will also need to set sp[:biometric_comparison_required] here to go with the above code change.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as above; I think this is too much for the stub. |
||
| end | ||
|
|
||
| context 'when selfie checks are enabled' do | ||
| let(:selfies_enabled) { true } | ||
|
|
||
| it 'returns true by default' do | ||
| expect(response.selfie_check_performed?).to be(true) | ||
| end | ||
| end | ||
|
|
||
| context 'when selfie checks are disabled' do | ||
| let(:selfies_enabled) { false } | ||
|
|
||
| it 'returns false by default' do | ||
| expect(response.selfie_check_performed?).to be(false) | ||
| end | ||
| end | ||
| end | ||
| end | ||
Uh oh!
There was an error while loading. Please reload this page.