Skip to content

Remove unused Profile::includes_phone_check? method #9815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthinz merged 1 commit into from
Dec 20, 2023
Merged

Remove unused Profile::includes_phone_check? method #9815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions app/models/profile.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,11 +279,6 @@ def self.build_compound_pii(pii)
values.join(':')
end

def includes_phone_check?
return false if proofing_components.blank?
proofing_components['address_check'] == 'lexis_nexis_address'
end

def irs_attempts_api_tracker
@irs_attempts_api_tracker ||= IrsAttemptsApi::Tracker.new
end
Expand Down
20 changes: 0 additions & 20 deletions spec/models/profile_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,26 +46,6 @@
end
end

describe '#includes_phone_check?' do
it 'returns true if the address_check component is lexis_nexis_address' do
profile = create(:profile, proofing_components: { address_check: 'lexis_nexis_address' })

expect(profile.includes_phone_check?).to eq(true)
end

it 'returns false if the address_check componet is gpo_letter' do
profile = create(:profile, proofing_components: { address_check: 'gpo_letter' })

expect(profile.includes_phone_check?).to eq(false)
end

it 'returns false if proofing_components is blank' do
profile = create(:profile, proofing_components: '')

expect(profile.includes_phone_check?).to eq(false)
end
end

describe '#in_person_verification_pending?' do
it 'returns true if the in_person_verification_pending_at is present' do
profile = create(
Expand Down