Skip to content

Update Brakeman and view_component #9813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 3 commits into from
Dec 20, 2023
Merged

Update Brakeman and view_component #9813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45bd3da
update view_component
Dec 20, 2023
8e21c9d
update brakeman
Dec 20, 2023
39a5f08
Use new method option for with_request_url
aduth Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ gem 'strong_migrations', '>= 0.4.2'
gem 'subprocess', require: false
gem 'terminal-table', require: false
gem 'valid_email', '>= 0.1.3'
gem 'view_component', '~> 3.0.0'
gem 'view_component', '~> 3.0'
gem 'webauthn', '~> 2.5.2'
gem 'xmldsig', '~> 0.6'
gem 'xmlenc', '~> 0.7', '>= 0.7.1'
Expand Down
6 changes: 3 additions & 3 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ GEM
bindata (2.4.15)
bootsnap (1.17.0)
msgpack (~> 1.2)
brakeman (6.0.1)
brakeman (6.1.0)
browser (5.3.1)
builder (3.2.4)
bullet (7.1.4)
Expand Down Expand Up @@ -684,7 +684,7 @@ GEM
activemodel
mail (>= 2.6.1)
simpleidn
view_component (3.0.0)
view_component (3.8.0)
activesupport (>= 5.2.0, < 8.0)
concurrent-ruby (~> 1.0)
method_source (~> 1.0)
Expand Down Expand Up @@ -842,7 +842,7 @@ DEPENDENCIES
tableparser
terminal-table
valid_email (>= 0.1.3)
view_component (~> 3.0.0)
view_component (~> 3.0)
webauthn (~> 2.5.2)
webmock
xmldsig (~> 0.6)
Expand Down
10 changes: 1 addition & 9 deletions spec/components/tab_navigation_component_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,7 @@
post '(:example_param)/second' => 'application#second_create'
end

with_request_url(request_path) do
vc_test_request.request_method = request_method
vc_test_request.path_parameters = Rails.application.routes.recognize_path_with_request(
vc_test_request,
request_path,
{},
)
example.run
end
with_request_url(request_path, method: request_method) { example.run }

Rails.application.reload_routes!
end
Expand Down