Skip to content

Adds fix for permissions with latest base image#981

Merged
jgrevich merged 3 commits intomasterfrom
amos-fix-deployments
Jan 28, 2017
Merged

Adds fix for permissions with latest base image#981
jgrevich merged 3 commits intomasterfrom
amos-fix-deployments

Conversation

@amoose
Copy link
Copy Markdown
Contributor

@amoose amoose commented Jan 24, 2017

Why

Deploying with capistrano results in a nginx 500 error

How

Modifies ownership of /srv directory post-deploy
Adds INT environment to available deployment stages

One major caveat is that capistrano's initial permissions on /srv/idp/current are not compatible with nginx/passenger and the site returns a 500 error while the chown task is running (10-30s).

@amoose amoose self-assigned this Jan 24, 2017
@amoose amoose requested a review from jgrevich January 24, 2017 23:25
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

config/deploy.rb Outdated
before 'assets:precompile', :browserify
after 'deploy:updated', 'newrelic:notice_deployment'
after 'deploy:log_revision', :deploy_json
after :deploy, 'deploy:mod_perms'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we make this a string 'deploy' for consistency?

@amoose
Copy link
Copy Markdown
Contributor Author

amoose commented Jan 26, 2017

Thanks Zach. I'm going to wait until @jgrevich gives green light for merge

@monfresh
Copy link
Copy Markdown
Contributor

@jgrevich Is this good to go?

@jgrevich
Copy link
Copy Markdown
Contributor

Yep, I think we can fix this server side and remove this code at some point. This works for now.

@jgrevich jgrevich merged commit dfa6ce2 into master Jan 28, 2017
@jgrevich jgrevich deleted the amos-fix-deployments branch January 28, 2017 03:44
amoose added a commit that referenced this pull request Mar 7, 2017
* Adds fix for permissions in /srv/idp

* Adds INT environment to deployment stages

* Makes :deploy a string for consistency
amoose added a commit that referenced this pull request Mar 8, 2017
* Adds fix for permissions in /srv/idp

* Adds INT environment to deployment stages

* Makes :deploy a string for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants