Merged
Conversation
changelog: Internal, Doc Auth, Validate zip code having zip+4 format.
eileen-nava
approved these changes
Dec 19, 2023
Contributor
eileen-nava
left a comment
There was a problem hiding this comment.
I reviewed the code and did a manual QA. Looks good!
aduth
reviewed
Dec 20, 2023
| def zipcode_valid? | ||
| return if zipcode.is_a?(String) && zipcode.present? | ||
|
|
||
| errors.add(:zipcode, generic_error, type: :zipcode) |
Contributor
There was a problem hiding this comment.
This appears to have been the only reference to the generic_error method, so we probably ought to remove the method definition as being unreachable code.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-1118: zip code validation
🛠 Summary of changes
Basic zip code validation for zip+4 for US and territories postal code format.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.