Fix and test for mismatched locale content#9801
Merged
Conversation
changelog: Bug Fixes, Identity Verification, Fix incorrect information collection disclosure content for French and Spanish
Contributor
Author
|
We're currently in a content freeze, so this cannot be merged. |
dawei-nava
reviewed
Dec 19, 2023
| locale = key.split('.', 2).first.to_sym | ||
| other_locales = LOCALE_SPECIFIC_CONTENT.keys - [locale] | ||
| expect(value).not_to match( | ||
| Regexp.union(*LOCALE_SPECIFIC_CONTENT.slice(*other_locales).values), |
Contributor
Author
|
This is exempt from the content freeze because it's not modifying English content. Related Slack discussion: https://gsa-tts.slack.com/archives/C0NGESUN5/p1703013201827089?thread_ts=1703012168.640379&cid=C0NGESUN5 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Fixes an issue where French and Spanish content are mismatched, contained within the others' locale data for identity verification information disclosure.
Also adds a new regression spec intended to try to catch these sorts of issues by checking for content patterns which are expected to only exist within specific locales.
See: https://github.com/18F/identity-idp/pull/9392/files#r1431752474
📜 Testing Plan
Repeat Testing Plan from #9392
Verify new tests pass:
Also observe that the tests would fail without the included content updates: