LG-11904 Add 50/50 state tests for opt in navigation#9798
LG-11904 Add 50/50 state tests for opt in navigation#9798JackRyan1989 merged 10 commits intomainfrom
Conversation
…4-test-opt-in-fifty-fifty-state
…to check for navigation issues during 50 50 state
| end | ||
|
|
||
| describe 'navigating to How To Verify from Agreement page in 50/50 state' do | ||
| context 'opt in false at start but true during navigation' do |
There was a problem hiding this comment.
in_person_proofing_opt_in_enabled can be enabled and a user can opt in or opt out. I think we should be very specific here. What do you think about something like 'in_person_proofing_opt_in_enabled is false at start but true during navigation' rather than 'opt in false'? If you like this, I'd suggest we make this change for each context block.
| end | ||
| end | ||
|
|
||
| context 'Going back from Hybrid Handoff with opt in enabled midstream' do |
There was a problem hiding this comment.
I don't see tests around going back from IPP.
There was a problem hiding this comment.
Since we aren't toggling IPP with this deploy, I wasn't sure that I wanted to capture it?
There was a problem hiding this comment.
This is a new flow/path so I thought a good idea, maybe too much/not necessary?
Previously, if the user was on verify/document_capture#prepare and went back- they'd go back to document capture- but in this case- they should go back to how to verify.
There was a problem hiding this comment.
Ok, sorry I misunderstood. Yeah let me write some specs handling the back from document capture cases. Thanks!
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
This is a good idea! Recommend combining specs in each context like I said in one of the comments, and otherwise looks good.
| it 'should not be bounced back from Hybrid Handoff to How to Verify' do | ||
| expect(page).to have_current_path(idv_hybrid_handoff_url) | ||
| allow(IdentityConfig.store).to receive(:in_person_proofing_opt_in_enabled) { true } | ||
| page.refresh |
There was a problem hiding this comment.
oooh i didn't know about refresh, very useful!
svalexander
left a comment
svalexander
left a comment
There was a problem hiding this comment.
this was a great idea, thanks for suggesting and implementing these specs!
JackRyan1989
deleted the
jryan/lg-11904-test-opt-in-fifty-fifty-state
branch
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
I know this is already merged, but I wanted to echo Shannon's comments. This is great stuff. I think this helps build a lot of confidence in the upcoming release.
| end | ||
|
|
||
| it 'skips when disabled and redirects to hybird handoff)' do | ||
| it 'skips when disabled and redirects to hybrid handoff' do |
5 participants
🎫 Ticket
🛠 Summary of changes
Added new specs to handle the following cases during page navigation around the opt-in IPP How To Verify controller. We wanted some tests in place to define and confirm the behavior of the system during the 50/50 state. To simulate ending up on an instance that has a different config value than the one available on the previous page, we refresh the page after toggling the configuration state and see what happens.
Conditions:
📜 Testing Plan
These are specs, so you can run them locally using rspec or view the output of the CI/CD here in Github.