LG-11743 - Ensure personal key works for GPO users#9791
Merged
Conversation
Spec to check profile reactivation for GPO-verified users. This is a bug reported by and believed fixed by Matt Hinz (see LG-11549), but we wanted a feature spec to test this exact scenario. changelog: Internal,Feature Specs,Added a feature spec for an issue in LG-11549 Co-authored by: Matt Hinz <matt.hinz@gsa.gov>
970771e to
d16e7f3
Compare
Contributor
Author
|
Dump of the test running: |
matthinz
suggested changes
Dec 19, 2023
Contributor
matthinz
left a comment
There was a problem hiding this comment.
I think something about this is not testing the exact scenario. I'm checking now to see if it is a "me" problem (basically, did I describe the issue correctly)
matthinz
reviewed
Dec 19, 2023
aduth
reviewed
Dec 19, 2023
Changed literals 'Sign out' and 'Continue' to reference strings files.
Used less spec infrastructure and more direct browser-driving.
matthinz
approved these changes
Dec 20, 2023
| RSpec.feature 'Password recovery via personal key for a GPO-verified user' do | ||
| include IdvStepHelper | ||
|
|
||
| let(:email) { 'cool_beagle@test.org' } |
Contributor
There was a problem hiding this comment.
minor nit: can we make this @example.com?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11743
🛠 Summary of changes
Added a spec to check profile reactivation for GPO-verified users.
This is a bug reported by and believed fixed by Matt Hinz (see LG-11549), but we wanted a feature spec to test this exact scenario.
Co-authored by: Matt Hinz matt.hinz@gsa.gov
📜 Testing Plan
[ ] Run the new feature spec using the command below
[ ] Verify that the system walks through creating a GPO-verified user, resetting their password, and then re-activating their profile with the personal key generated during GPO verification.
SHOW_BROWSER=true bundle exec rspec spec/features/users/profile_recovery_for_gpo_verified_spec.rb