LG 11763 Include new device in MFA analytics#9784
Merged
kevinsmaster5 merged 21 commits intomainfrom Jan 5, 2024
Merged
Conversation
…or Authentication event
kevinsmaster5
force-pushed
the
kmas-lg-11763-new-device-mfa-analytics
branch
from
82f0aa2 to
b4dc743
Compare
aduth
reviewed
Dec 21, 2023
mdiarra3
reviewed
Dec 21, 2023
aduth
reviewed
Jan 2, 2024
zachmargolis
reviewed
Jan 2, 2024
app/controllers/two_factor_authentication/backup_code_verification_controller.rb
Outdated
Show resolved
Hide resolved
zachmargolis
reviewed
Jan 2, 2024
app/controllers/two_factor_authentication/otp_verification_controller.rb
Outdated
Show resolved
Hide resolved
aduth
approved these changes
Jan 3, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
I left a few minor comments, but this looks good, and works in my testing! 👍
spec/controllers/two_factor_authentication/otp_verification_controller_spec.rb
Outdated
Show resolved
Hide resolved
aduth
reviewed
Jan 4, 2024
spec/controllers/two_factor_authentication/otp_verification_controller_spec.rb
Outdated
Show resolved
Hide resolved
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11763
🛠 Summary of changes
Adds property to Multi-Factor Authentication event declaring whether or not a new device is in use.
📜 Testing Plan