Merged
Conversation
jessieay
approved these changes
Jan 23, 2017
Contributor
jessieay
left a comment
jessieay
left a comment
There was a problem hiding this comment.
Looks great! Perhaps add a note about this in the readme or something so we have somewhere to point people when they ask about switching locales?
Contributor
Author
|
Good idea. Will add to readme. |
**Why**: To make it easier to switch between English and Spanish, and to see what has and has not yet been translated. **How**: Add a before action in ApplicationController to set the locale based on the URL param if it is present, or fall back to the default. Note that eventually, we might implement something more user friendly, such as fetching the locale from the domain name, such as login.gov.es or es.login.gov, or perhaps in the path, like login.gov/es/profile.
monfresh
force-pushed
the
mb-allow-locale-switching
branch
from
dd26ee2 to
ead38f8
Compare
Contributor
Author
|
Readme updated. PTAL. |
Contributor
|
Looks good! Merge away |
amoose
pushed a commit
that referenced
this pull request
Feb 7, 2017
**Why**: To make it easier to switch between English and Spanish, and to see what has and has not yet been translated. **How**: Add a before action in ApplicationController to set the locale based on the URL param if it is present, or fall back to the default. Note that eventually, we might implement something more user friendly, such as fetching the locale from the domain name, such as login.gov.es or es.login.gov, or perhaps in the path, like login.gov/es/profile.
amoose
pushed a commit
that referenced
this pull request
Feb 24, 2017
**Why**: To make it easier to switch between English and Spanish, and to see what has and has not yet been translated. **How**: Add a before action in ApplicationController to set the locale based on the URL param if it is present, or fall back to the default. Note that eventually, we might implement something more user friendly, such as fetching the locale from the domain name, such as login.gov.es or es.login.gov, or perhaps in the path, like login.gov/es/profile.
amoose
pushed a commit
that referenced
this pull request
Feb 28, 2017
**Why**: To make it easier to switch between English and Spanish, and to see what has and has not yet been translated. **How**: Add a before action in ApplicationController to set the locale based on the URL param if it is present, or fall back to the default. Note that eventually, we might implement something more user friendly, such as fetching the locale from the domain name, such as login.gov.es or es.login.gov, or perhaps in the path, like login.gov/es/profile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: To make it easier to switch between English and Spanish, and
to see what has and has not yet been translated.
How: Add a before action in ApplicationController to set the locale
based on the URL param if it is present, or fall back to the default.
Note that eventually, we might implement something more user friendly,
such as fetching the locale from the domain name, such as login.gov.es
or es.login.gov, or perhaps in the path, like login.gov/es/profile.