Conversation
jessieay
approved these changes
Jan 23, 2017
Contributor
jessieay
left a comment
jessieay
left a comment
There was a problem hiding this comment.
One suggestion. Overall, this makes me very happy, as I am also used to env vars being all caps all the time
config/initializers/proofer.rb
Outdated
Contributor
There was a problem hiding this comment.
what this does is pretty straightforward, but a test might be good just as a form of documentation. I can imagine someone trying to add a lowercase env var and not knowing why it is always getting uppercased
Contributor
Author
|
thanks @jessieay -- I refactored the initializer code into |
jessieay
approved these changes
Jan 23, 2017
Contributor
jessieay
left a comment
jessieay
left a comment
There was a problem hiding this comment.
Code climate isn't pleased, but I am!
**Why**: Vendor-specific drivers all expect UPPER case env vars.
amoose
pushed a commit
that referenced
this pull request
Feb 7, 2017
**Why**: Vendor-specific drivers all expect UPPER case env vars.
amoose
pushed a commit
that referenced
this pull request
Feb 24, 2017
**Why**: Vendor-specific drivers all expect UPPER case env vars.
amoose
pushed a commit
that referenced
this pull request
Feb 28, 2017
**Why**: Vendor-specific drivers all expect UPPER case env vars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Vendor-specific drivers all expect UPPER case env vars.