Add support for JavaScript-driven client-side OIDC interstitial redirect#9755
Merged
mitchellhenke merged 5 commits intomainfrom Dec 13, 2023
Merged
Add support for JavaScript-driven client-side OIDC interstitial redirect#9755mitchellhenke merged 5 commits intomainfrom
mitchellhenke merged 5 commits intomainfrom
Conversation
added 2 commits
December 13, 2023 11:15
changelog: Internal, OpenID Connect, Add support for client-side OIDC redirect
| private | ||
|
|
||
| def redirect_user(redirect_uri) | ||
| if IdentityConfig.store.openid_connect_redirect == :client_side |
Contributor
There was a problem hiding this comment.
ditto re case/when and default branch
Contributor
Author
There was a problem hiding this comment.
Thanks, reads a lot better, changed in 5195194
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
zachmargolis
approved these changes
Dec 13, 2023
mitchellhenke
force-pushed
the
mitchellhenke/oidc-js-redirect
branch
from
3642248 to
63757f5
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This is a follow-up to #9669 to add a different option for client-side redirect by using JavaScript rather than the HTTP
metatag.