Conversation
jmhooper
force-pushed
the
jmhooper-replace-pii-cacher-with-profile-cacher
branch
4 times, most recently
from
3cea41f to
9b54e12
Compare
…` implementation The `Pii::ProfileCacher` was implemented in #9509. As described in that pull request: > The Pii::ProfileCacher class implements the same API as Pii::Cacher and is intended to supersede Pii::Cacher when this work is done. All of the invocations to `Pii::Cacher` that require the deprecated profile-unaware functionality have been removed and the new profile-aware functionality is fully implemented and in-user. This commit does the work of moving the `Pii::ProfileCacher` functionality into `Pii::Cacher` and removing `Pii::ProfileCacher` This should not be merged until both `session_encrypted_profiles_read_enabled` and `session_encrypted_profiles_write_enabled` have been set to true. This commit removes those feature flags and assumes they are set to true. changelog: Internal, Profile and session management, The pii cacher implementation was replaced with the profile cacher implementation
jmhooper
force-pushed
the
jmhooper-replace-pii-cacher-with-profile-cacher
branch
from
9b54e12 to
351ca6a
Compare
soniaconnolly
approved these changes
Dec 13, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Pii::ProfileCacherwas implemented in #9509. As described in that pull request:All of the invocations to
Pii::Cacherthat require the deprecated profile-unaware functionality have been removed and the new profile-aware functionality is fully implemented and in-use. This commit does the work of moving thePii::ProfileCacherfunctionality intoPii::Cacherand removingPii::ProfileCacher.This should not be merged until both
session_encrypted_profiles_read_enabledandsession_encrypted_profiles_write_enabledhave been set to true. This commit removes those feature flags and assumes they are set to true.