LG-11878: Change Use of Compact in True ID Request#9751
Merged
eileen-nava merged 2 commits intomainfrom Dec 13, 2023
Merged
Conversation
eileen-nava
requested review from
a team and
night-jellyfish
and removed request for
a team
jmhooper
approved these changes
Dec 13, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11878: Fix compact bug in true_id_request.rb
🛠 Summary of changes
While investigating a decrease in True ID success rates, Timnit team members pointed out a bug in the use of
compact. Here's a relevant Slack post. Further in the debugging process, team members confirmed that the use ofcompactdid not cause this bug. Here's another relevant Slack post. I am still sharing this PR for review, but I want to call out that I don't think it addresses the root cause of the change in True ID success rates.📜 Testing Plan
Run automated tests