Removes noisy puts statement

[amoose]

Why

We have a special rake task for running user flow specs, but only when RSpec is present.

How

Removes noisy puts statement and fails silently since Rails.logger isn't available.

[monfresh]

LGTM, but out of curiosity, in what scenario would RSpec not be present?

[monfresh]

And if RSpec is really not present, why fail silently? If the rake task depends on RSpec, don't we want to let the LoadError be raised?

[amoose]

RSpec is not present in production; where the bundle is without development, test, etc. We do not want to raise the exception because this rake task is only meant to be available in the development/test environments. It will only work, in fact, if the test group is included.

[amoose]

I guess the other option would be to put this entire task in a big conditional? What do you think the best way to handle this is?

[monfresh]

I'm still not quite sure what the problem we're trying to solve is. If someone attempts to run the rake task in production, raising an error seems reasonable to me since it's not meant to be run in production. Is the issue that the rake task somehow is getting invoked automatically when deploying or cooking our servers?

[monfresh]

I get it now. Whenever rake is invoked, it loads all rake tasks, and triggers the rescue in production. I would suggest wrapping the task in a conditional, like you suggested, and removing the rescue:

unless Rails.env.production?
  namespace :spec do
    desc 'Executes user flow specs'
    RSpec::Core::RakeTask.new('user_flows') do |t|
      t.rspec_opts = %w[--tag user_flow
                        --order defined
                        --require ./lib/rspec/formatters/user_flow_formatter.rb
                        --format UserFlowFormatter]
    end
  end
end

[monfresh]

Pinging @amoose. If you're busy with other things, do you want me to make the change I recommended so we can merge this?

[amoose]

Yes, that would be great Moncef, thanks!

[monfresh]

LGTM