-
Notifications
You must be signed in to change notification settings - Fork 166
LG-11671: Lexisnexis Instant Verify workflow A/B test #9743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
075b707
Add config vars and ab test infrastructure for LexisNexis Instant Ver…
soniaconnolly 409251a
Include LN InstantVerify A/B test args in the analytics
solipet a678fd0
Convert Idv::LexisnexisInstantVerify from module to class
solipet 73c16a0
spec for Idv::LexisnexisInstantVerify
solipet 4e6ee3b
changelog
solipet 39cc370
Add progressive proofer spec for instant verify workflow A/B test
soniaconnolly 618ad06
Update analytics_spec with new bucket
soniaconnolly 9bab679
Beautify lexisnexis_instant_verify_spec
soniaconnolly 6186a68
pass the document_capture_session_uuid to the ResolutionProofingJob#p…
solipet 372eba9
final cleanup
solipet fc47d1d
More analytics_spec fixes
soniaconnolly a55b7f3
Spec to confirm that resolution_proofing_job works with nil document_…
soniaconnolly fd1a821
Make document_capture_session_uuid arg optional in resolution_proofin…
soniaconnolly 5a0db93
Put in alternate workflow name so it will be ready when we turn it on
soniaconnolly fb42ca5
In ProgressiveProofer, name argument instant_verify_ab_test_discrimin…
soniaconnolly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| module Idv | ||
| class LexisnexisInstantVerify | ||
| attr_reader :document_capture_session_uuid | ||
|
|
||
| def initialize(document_capture_session_uuid) | ||
| @document_capture_session_uuid = document_capture_session_uuid | ||
| end | ||
|
|
||
| def workflow_ab_test_analytics_args | ||
| { | ||
| lexisnexis_instant_verify_workflow_ab_test_bucket: | ||
| AbTests::LEXISNEXIS_INSTANT_VERIFY_WORKFLOW.bucket(document_capture_session_uuid), | ||
| } | ||
| end | ||
|
|
||
| def workflow_ab_testing_variables | ||
| bucket = AbTests::LEXISNEXIS_INSTANT_VERIFY_WORKFLOW.bucket(document_capture_session_uuid) | ||
| testing_enabled = IdentityConfig.store.lexisnexis_instant_verify_workflow_ab_testing_enabled | ||
| use_alternate_workflow = (bucket == :use_alternate_workflow) | ||
|
|
||
| if use_alternate_workflow | ||
| instant_verify_workflow = IdentityConfig.store.lexisnexis_instant_verify_workflow_alternate | ||
| else | ||
| instant_verify_workflow = IdentityConfig.store.lexisnexis_instant_verify_workflow | ||
| end | ||
|
|
||
| { | ||
| ab_testing_enabled: testing_enabled, | ||
| use_alternate_workflow: use_alternate_workflow, | ||
| instant_verify_workflow: instant_verify_workflow, | ||
| } | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always have to 🤔 about whether
_percentmeans the number that gets the "A" variant or the "B" variant. Not something we have to fix in this PR though!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears to be the percentage on the alternate, but I always wonder too. Especially since there are comments sprinkled around the Acuant code saying it has no effect? We'll definitely have to check on that in the next PR.