Conversation
|
@rtwell hello! Just missing a couple of icons for this ticket:
Also, something about the letter spacing in the screenshot seems weird. Should this screen be using a different font? |
|
Might just be me, but when I see this it looks like a list of recovery keys rather than a single one, since I am used to other services giving me a list of recovery codes when signing up. Did we test this new design at all? Wondering if others would see the same thing. |
el-mapache
force-pushed
the
ab-stacked-pkey
branch
2 times, most recently
from
f882311 to
8350ed3
Compare
|
@jessieay we're going to test this one! and the screen to enter your key looks like this:
|
|
@el-mapache can we make the personal key type the Navy blue? |
el-mapache
force-pushed
the
ab-stacked-pkey
branch
from
8350ed3 to
12c5f12
Compare
|
@rtwell whoops, forgot to push that. It looks very dark on the text though |
|
nice and high contrast! love it. thanks! |
There was a problem hiding this comment.
These color classes already exist with basscss, you can access them with .blue and .navy. We have all of these http://basscss.com/v7/docs/colors/ defined in stylesheets/variables/colors.
There was a problem hiding this comment.
Ah, I was trying to find the color classes, I thought they were ours, not basecss
There was a problem hiding this comment.
@hursey013 I removed the redundant class definitions and also an unnecessary color class in the markup
**Why**: To make the code easier for the user to write down
el-mapache
force-pushed
the
ab-stacked-pkey
branch
from
12c5f12 to
c60b5dc
Compare
| @@ -0,0 +1,14 @@ | |||
| #recovery-code(class="col-12 border-box mt4 mb3 py2 px3 fs-20p sans-serif\ | |||
| border border-dashed border-red rounded-xl relative") | |||
There was a problem hiding this comment.
If we wind up using this pattern anywhere else we can probably roll some of this up into a new class, but fine for now.
**Why**: To make the code easier for the user to write down
**Why**: To make the code easier for the user to write down
4 participants
Why: To make the code easier for the user to write down
Screenshot: