Fix the headless mode used by Selenium#9734
Closed
night-jellyfish wants to merge 3 commits intomainfrom
Closed
Conversation
aduth
approved these changes
Dec 8, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM assuming CI is happy with it 👍
night-jellyfish
force-pushed
the
brittany/fix-selenium-issue
branch
from
52be51a to
72d7145
Compare
dockerfiles/idp_ci.Dockerfile
Outdated
Contributor
There was a problem hiding this comment.
we'll have to update gitlab-ci.yml with the updated image
night-jellyfish
force-pushed
the
brittany/fix-selenium-issue
branch
3 times, most recently
from
846444c to
1dc6f14
Compare
mitchellhenke
approved these changes
Dec 12, 2023
night-jellyfish
force-pushed
the
brittany/fix-selenium-issue
branch
4 times, most recently
from
a875869 to
134b1e4
Compare
[See this documentation for details on the change](https://www.selenium.dev/blog/2023/headless-is-going-away/) and [this conversation in Slack for discussion](https://gsa-tts.slack.com/archives/C0NGESUN5/p1702068737905679). (note: we found we had to make an adjustment for CI in the following commit. The hope is that we can come back to this in the future.) Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
See [this Slack thread](https://gsa-tts.slack.com/archives/C0NGESUN5/p1702323692159879?thread_ts=1702068737.905679&cid=C0NGESUN5) for more details. Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
night-jellyfish
force-pushed
the
brittany/fix-selenium-issue
branch
from
134b1e4 to
66227ea
Compare
night-jellyfish
pushed a commit
that referenced
this pull request
Dec 14, 2023
This fixes local dev for Chromedriver v120. We found that upgrading Chromedriver to v120 in Docker for CI caused all sorts of issues, so for the time being we are not upgrading CI. This is a workaround from the failures in #9734. [See this documentation for details on the change](https://www.selenium.dev/blog/2023/headless-is-going-away/), [this conversation in Slack for discussion](https://gsa-tts.slack.com/archives/C0NGESUN5/p1702068737905679), and [this issue on Chromedriver](https://bugs.chromium.org/p/chromedriver/issues/detail?id=4440).
Contributor
Author
|
Even though this eventually passed, it failed several times (only passing 2 / 14 CI runs). Closing this PR in favor of #9767. The changes here might eventually be needed to upgrade Chromedriver in CI, but that doesn't work currently. |
night-jellyfish
added a commit
that referenced
this pull request
Dec 15, 2023
* changelog: Internal, Local setup, Fix headless mode used by Selenium locally This fixes local dev for Chromedriver v120. We found that upgrading Chromedriver to v120 in Docker for CI caused all sorts of issues, so for the time being we are not upgrading CI. This is a workaround from the failures in #9734. [See this documentation for details on the change](https://www.selenium.dev/blog/2023/headless-is-going-away/), [this conversation in Slack for discussion](https://gsa-tts.slack.com/archives/C0NGESUN5/p1702068737905679), and [this issue on Chromedriver](https://bugs.chromium.org/p/chromedriver/issues/detail?id=4440).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Changes the headless mode used by Selenium.
See this documentation for details on the change and this conversation in Slack for discussion.