Skip to content

Remove background jobs and tooling for multi-region KMS migration#9732

Merged
jmhooper merged 1 commit intomainfrom
jmhooper-remove-mr-kms-tooling
Dec 14, 2023
Merged

Remove background jobs and tooling for multi-region KMS migration#9732
jmhooper merged 1 commit intomainfrom
jmhooper-remove-mr-kms-tooling

Conversation

@jmhooper
Copy link
Contributor

@jmhooper jmhooper commented Dec 8, 2023

The multi-region KMS migration involved changes to migrate password digests and encrypted PII ciphertexts away from a KMS instance that used a single key to one that supports multi-region keys. This was done with a background job and tooling that would decrypt with the single region key and re-encrypt with the multi-region key.

All of the migrateable records have been migrated at this point so this job, its configuration, and the tooling to support it are not longer necessary.

@jmhooper jmhooper requested a review from a team December 8, 2023 18:21
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete_stats++

Comment on lines 317 to 319
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the other configurations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch; just cleaned up

The multi-region KMS migration involved changes to migrate password digests and encrypted PII ciphertexts away from a KMS instance that used a single key to one that supports multi-region keys. This was done with a background job and tooling that would decrypt with the single region key and re-encrypt with the multi-region key.

All of the migrateable records have been migrated at this point so this job, its configuration, and the tooling to support it are not longer necessary.

[skip changelog]
@jmhooper jmhooper force-pushed the jmhooper-remove-mr-kms-tooling branch from 7b19f59 to 59f3050 Compare December 14, 2023 20:44
@jmhooper jmhooper merged commit 42a4175 into main Dec 14, 2023
@jmhooper jmhooper deleted the jmhooper-remove-mr-kms-tooling branch December 14, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants