Skip to content

Write deploy.json file for review apps #9722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 14 commits into from
Dec 7, 2023
Merged

Write deploy.json file for review apps #9722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e18e02d
Try writing deploy.json file for review apps
zachmargolis Dec 6, 2023
01d94e9
Try writing deploy.json in the dockerfile
zachmargolis Dec 6, 2023
9b1a6ce
tweak heredoc syntax
zachmargolis Dec 6, 2023
690d27a
try COPY command
zachmargolis Dec 6, 2023
e38acca
update arg_ env_ variable dance
zachmargolis Dec 6, 2023
f498f37
newlines
zachmargolis Dec 6, 2023
7c6a081
echo env vars
zachmargolis Dec 6, 2023
a60d006
arg_
zachmargolis Dec 6, 2023
fdc07e3
debug print statement
zachmargolis Dec 6, 2023
d9c9a88
build-args on one line
zachmargolis Dec 7, 2023
d8b30fa
separate lines for readability
zachmargolis Dec 7, 2023
e68e8d7
Remove heredoc syntax
zachmargolis Dec 7, 2023
f4e76d7
move echo after chowns
zachmargolis Dec 7, 2023
cf000c1
Nested under api directory
zachmargolis Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ build-review-image:
- mkdir -p /kaniko/.docker
- echo ${CI_ENVIRONMENT_SLUG}
- echo $CI_ENVIRONMENT_SLUG
- echo $CI_COMMIT_BRANCH
- echo $CI_COMMIT_SHA
- |-
KANIKOCFG="\"credsStore\":\"ecr-login\""
if [ "x${http_proxy}" != "x" -o "x${https_proxy}" != "x" ]; then
Expand All @@ -134,7 +136,12 @@ build-review-image:
--cache-ttl=168h
--cache=true
--compressed-caching=false
--build-arg "http_proxy=${http_proxy}" --build-arg "https_proxy=${https_proxy}" --build-arg "no_proxy=${no_proxy}" --build-arg "ARG_CI_ENVIRONMENT_SLUG=${CI_ENVIRONMENT_SLUG}"
--build-arg "http_proxy=${http_proxy}"
--build-arg "https_proxy=${https_proxy}"
--build-arg "no_proxy=${no_proxy}"
--build-arg "ARG_CI_ENVIRONMENT_SLUG=${CI_ENVIRONMENT_SLUG}"
--build-arg "ARG_CI_COMMIT_BRANCH=${CI_COMMIT_BRANCH}"
--build-arg "ARG_CI_COMMIT_SHA=${CI_COMMIT_SHA}"

check_changelog:
stage: test
Expand Down
7 changes: 7 additions & 0 deletions dockerfiles/idp_review_app.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@ FROM ruby:3.2.2-slim

# Set environment variables
ARG ARG_CI_ENVIRONMENT_SLUG="placeholder"
ARG ARG_CI_COMMIT_BRANCH="branch_placeholder"
ARG ARG_CI_COMMIT_SHA="sha_placeholder"
ENV CI_ENVIRONMENT_SLUG=${ARG_CI_ENVIRONMENT_SLUG}
ENV CI_COMMIT_BRANCH=${ARG_CI_COMMIT_BRANCH}
ENV CI_COMMIT_SHA=${ARG_CI_COMMIT_SHA}
ENV RAILS_ROOT /app
ENV RAILS_ENV production
ENV NODE_ENV production
Expand Down Expand Up @@ -124,6 +128,9 @@ COPY --chown=app:app ./babel.config.js ./babel.config.js
COPY --chown=app:app ./webpack.config.js ./webpack.config.js
COPY --chown=app:app ./.browserslistrc ./.browserslistrc

RUN mkdir -p $RAILS_ROOT/public/api/
RUN echo "{\"branch\":\"$CI_COMMIT_BRANCH\",\"git_sha\":\"$CI_COMMIT_SHA\"}" > $RAILS_ROOT/public/api/deploy.json

# Copy keys
COPY --chown=app:app keys.example $RAILS_ROOT/keys

Expand Down