Skip to content

Active_support blank requirement for bin/query-cloudwatch#9708

Merged
henrydrichardson merged 1 commit intomainfrom
henrydrich/require-query-cloudwatch
Dec 5, 2023
Merged

Active_support blank requirement for bin/query-cloudwatch#9708
henrydrichardson merged 1 commit intomainfrom
henrydrich/require-query-cloudwatch

Conversation

@henrydrichardson
Copy link
Contributor

🛠 Summary of changes

This PR adds a new require statement for bin/query-cloudwatch to satisfy dependencies.

👀 Behavior

If relevant, include a screenshot or screen capture of the changes.

Before: Example Query:

bin/query-cloudwatch --from 7d --env henrydrich --app idp --log events.log --query "fields @timestamp | limit 20"

Error Message:

bin/query-cloudwatch:260:in `parse!': undefined method `blank?' for "events.log":String (NoMethodError)

    if (app = config.app) && (env = config.env) && !(log = config.log).blank?
                                                                      ^^^^^^^
	from bin/query-cloudwatch:315:in `<main>'
After: Example Query:

bin/query-cloudwatch --from 7d --env henrydrich --app idp --log events.log --query "fields @timestamp | limit 20"

Output:

Querying log slices 100% [1/1] |=========================================| Time: 00:00:03
2023-12-05 17:00:07.783

@henrydrichardson henrydrichardson merged commit bace4d5 into main Dec 5, 2023
@henrydrichardson henrydrichardson deleted the henrydrich/require-query-cloudwatch branch December 5, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants