LG-11654: Enable React (and React Hook) Lint Rules for One File#9706
Merged
LG-11654: Enable React (and React Hook) Lint Rules for One File#9706
Conversation
charleyf
changed the title
charleyf
commented
Dec 7, 2023
charleyf
commented
Dec 7, 2023
charleyf
commented
Dec 8, 2023
eileen-nava
reviewed
Dec 13, 2023
app/javascript/packages/document-capture/components/acuant-camera.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Calling this out since it's a shift from my original intentions with this PR. Enabling hook linting for |
…w gradual enablement
aduth
reviewed
Dec 14, 2023
aduth
approved these changes
Dec 14, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Couple questions, but LGTM otherwise 👍
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-11654
🛠 Summary of changes
This PR is an experimental way to turn on react linting very selectively. It's meant as a way for me to get comments on approach, and also hopefully allow us to move towards using reacts recommended lint rules to avoid bugs.
📜 Testing Plan
Test that the document upload flow continues to work. Make sure the troubleshooting options appear correctly. To see them, you'll need to upload the failing document yaml file.