Skip to content

LG-11551 Read the correct PII for resend letter #9701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theabrad merged 3 commits into from
Dec 5, 2023
Merged

LG-11551 Read the correct PII for resend letter #9701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f579dba
read correct pii for resend letter
theabrad Nov 30, 2023
418b33a
add fake pii to tests
theabrad Dec 4, 2023
ebf9078
add changelog
theabrad Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/controllers/idv/by_mail/request_letter_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,14 +112,19 @@ def resend_letter

def confirmation_maker_perform
confirmation_maker = GpoConfirmationMaker.new(
pii: Pii::Cacher.new(current_user, user_session).fetch,
pii: pii,
service_provider: current_sp,
profile: current_user.pending_profile,
)
confirmation_maker.perform
confirmation_maker
end

def pii
Pii::Cacher.new(current_user, user_session).
fetch(current_user.gpo_verification_pending_profile.id)
end

def send_reminder
current_user.send_email_to_all_addresses(:letter_reminder)
end
Expand Down
6 changes: 3 additions & 3 deletions spec/controllers/idv/by_mail/request_letter_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@

context 'resending a letter' do
let(:has_pending_profile) { true }
let(:pending_profile) { create(:profile, :verify_by_mail_pending) }
let(:pending_profile) { create(:profile, :with_pii, :verify_by_mail_pending) }

before do
stub_sign_in(user)
Expand Down Expand Up @@ -245,9 +245,9 @@
end

def expect_resend_letter_to_send_letter_and_redirect(otp:)
pii = { first_name: 'Samuel', last_name: 'Sampson' }
pii = pending_profile.decrypt_pii(user.password).to_h
pii_cacher = instance_double(Pii::Cacher)
allow(pii_cacher).to receive(:fetch).and_return(pii)
allow(pii_cacher).to receive(:fetch).with(pending_profile.id).and_return(pii)
allow(pii_cacher).to receive(:exists_in_session?).and_return(true)
allow(Pii::Cacher).to receive(:new).and_return(pii_cacher)

Expand Down