Skip to content

Fix header casing for Rack 3#9699

Merged
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/fix-header-casing
Dec 4, 2023
Merged

Fix header casing for Rack 3#9699
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/fix-header-casing

Conversation

@mitchellhenke
Copy link
Contributor

Follow up to #9359 where there was an issue with requests failing due to headers not being lowercase. Issue reported here.

I wasn't able to find a good way to test the public file server headers though.

changelog: Bug Fixes, Dependencies, Fix header casing for Rack 3
@aduth
Copy link
Contributor

aduth commented Dec 4, 2023

I wasn't able to find a good way to test the public file server headers though.

I think this'll happen if you compile in a separate process from make run such that the typical Webpack development server isn't used.

e.g.

yarn build && yarn build:css
# or: rails assets:precompile
rails s

I just did this and confirmed the headers are now lowercase.

@eileen-nava eileen-nava self-requested a review December 4, 2023 21:14
Copy link
Contributor

@charleyf charleyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solved the problem for me.

@mitchellhenke mitchellhenke merged commit 5949cb2 into main Dec 4, 2023
@mitchellhenke mitchellhenke deleted the mitchellhenke/fix-header-casing branch December 4, 2023 21:27
@solipet solipet mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants