LG-11670: Add small feature test for selfie flow#9677
Merged
night-jellyfish merged 3 commits intomainfrom Nov 29, 2023
Merged
Conversation
night-jellyfish
requested review from
a team and
amirbey
and removed request for
a team
night-jellyfish
force-pushed
the
brittany/lg-11670-integrate-and-test-selfie-fe-and-be
branch
from
5ed00ad to
f4c4802
Compare
charleyf
approved these changes
Nov 29, 2023
Contributor
charleyf
left a comment
charleyf
left a comment
There was a problem hiding this comment.
This is a good test to have and the methodology makes sense to me, it's very inline with the other tests in document_capture_spec.rb.
amirbey
reviewed
Nov 29, 2023
amirbey
approved these changes
Nov 29, 2023
night-jellyfish
force-pushed
the
brittany/lg-11670-integrate-and-test-selfie-fe-and-be
branch
from
f4c4802 to
39002b8
Compare
night-jellyfish
deleted the
brittany/lg-11670-integrate-and-test-selfie-fe-and-be
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11670
🛠 Summary of changes
Adding a small feature test for the selfie flow, now that we have a selfie back end and front end.
🎶 Technical notes
This ticket was more about manual testing and writing tickets and less about changing code, but I did find myself writing this test as part of the work, and figured it might be worth keeping.
Given the tests that were added in #9561 and #9676, I also wasn't able to come up with many other tests that might be needed. It seems like maybe there's another place for a front / back end integration spec that I'm missing. I'm open to feedback if folks think there are other tests that might be needed.