Skip to content

LG-11463 LG-11722 Allow browser Back button from Enter Password step#9662

Merged
soniaconnolly merged 52 commits intomainfrom
doug-lg-11463-back-from-phone-step-cherrypicked
Nov 29, 2023
Merged

LG-11463 LG-11722 Allow browser Back button from Enter Password step#9662
soniaconnolly merged 52 commits intomainfrom
doug-lg-11463-back-from-phone-step-cherrypicked

Conversation

@soniaconnolly
Copy link
Contributor

@soniaconnolly soniaconnolly commented Nov 27, 2023 •
edited by tahineemay
Loading

🎫 Ticket

LG-11463
LG-11722

🛠 Summary of changes

Allow the browser back button from Welcome up to visiting Enter Password. This includes RequestLetter from Verify by Mail, and the in-person Ssn and VerifyInfo controllers. If the user re-submits an earlier step, all future steps are cleared from the session.

Note: In-person VerifyInfo still prevents going back, and we'll address that in a separate PR.

Do not merge until #9645 is deployed, since we need all sessions to have pii_from_user/pii_from_doc available after VerifyInfo is submitted.

📜 Testing Plan

  • In application.yml, add in_person_proofing_opt_in_enabled: true to include the new HowToVerify controller in testing
  • Create account, start IdV
  • Use the back button liberally up to EnterPassword
  • Expect to be able to go back/forward without issues
  • Resubmit a step, try to jump forward past that step
  • Expect to be redirected back to the next step after the one submitted
  • On phone step, choose Verify by Mail
  • Request letter, enter password
  • Expect no longer to be able to to go back from LetterEnqueued ("Come back later") page
  • Sign in, expect to land on EnterCode
  • Try to jump to other pages in IdV, expect to stay on EnterCode
  • EnterCode, expect to see PersonalKey
  • Try to jump to other pages in IdV, expect to stay on PersonalKey
  • Complete PersonalKey
  • Create new account, start IdV
  • On HowToVerify, choose in person proofing
  • Repeat above steps
  • Expect to be able to go back until in-person VerifyInfo

@soniaconnolly soniaconnolly mentioned this pull request Nov 27, 2023
Closed
@solipet solipet force-pushed the doug-lg-11463-back-from-phone-step-cherrypicked branch from a15461c to 5b7167b Compare November 27, 2023 23:17
@solipet solipet marked this pull request as ready for review November 28, 2023 00:02
@soniaconnolly soniaconnolly requested review from a team November 28, 2023 00:25
soniaconnolly
soniaconnolly commented Nov 28, 2023
View reviewed changes
soniaconnolly
soniaconnolly commented Nov 28, 2023
View reviewed changes
@soniaconnolly soniaconnolly force-pushed the doug-lg-11463-back-from-phone-step-cherrypicked branch from 33336e6 to 86c18f6 Compare November 28, 2023 16:25
@soniaconnolly soniaconnolly changed the title LG-11463 Allow browser Back button from Enter Password step LG-11463 LG-11722 Allow browser Back button from Enter Password step Nov 28, 2023
soniaconnolly and others added 20 commits November 28, 2023 12:17
@soniaconnolly
Include PhoneController and OtpVerificationController in FlowPolicy
4a3e49d 
changelog: User-facing Improvements, Identity Verification back button, Allow back button for Phone step
@soniaconnolly
Add :confirm_step_allowed to OtpVerificationController
7dc7eac 
Added Idv::Session#ssn_step_complete? which checks whether verify_info step is complete.
Also add action: :new to PhoneController.step_info
@soniaconnolly @solipet
Add RequestLetter StepInfo
f76e16d 
Co-authored-by: Doug Price <douglas.price@gsa.gov>
@soniaconnolly
Specify controller module in url_for
f580bf2 
The default of /idv was working until we got to /idv/by_mail/request_letter, so make the default
/idv and allow specifying a different module for RequestLetterController.step_info. Use the module
to build an absolute controller path in url_for.
@soniaconnolly
Allow back button starting from Enter Password step
a25f2ee 
Add ssn_or_applicant_ssn and pii_from_doc_or_applicant and pii_from_user_or_applicant to idv_session
to make Ssn and VerifyInfo pages work after pii is moved to idv_session.applicant
Remove :confirm_verify_info_step_needed before actions
@solipet @soniaconnolly
use tail recursion when undoing steps
55dc49b
@solipet @theabrad @soniaconnolly
adds clear_current_step! for verify_info's undo_step proc
ec2cc00 
adds restore_pii_from_doc and restore_pii_from_user

Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov>
@solipet @soniaconnolly @theabrad
Add step_info for IPP controllers outside FSM.
b0fdf08 
StepInfo now takes the controller class as a parameter in the
initializer, then converts the controller to the full string name,
including modules, for use in url_for. This disambiguates between remote
idv and in person for ssn and verify_info controllers.

Removed controller_module from StepInfo since the above make it
unneeded.

Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov>
@solipet @soniaconnolly
specs on step_info for ipp/gpo controllers
c1ef77e
@solipet @soniaconnolly
fix in_person verify_info_controller_spec
3eb78f2
@solipet @soniaconnolly
fix specs for Idv::AddressController, delete outdated helper
884a195
@solipet @soniaconnolly
Add clear_future_steps! to IPP controllers.
6ba97ce 
Deleted clear_current_step! in favor of explicitly restoring the pii
from the applicant.
@solipet @soniaconnolly
wip
50eadf8
@solipet @soniaconnolly
wip2
0c4c6ac
@solipet @soniaconnolly
remove pii_or_applicant methods, restore clear_current_step
2e7ab52
@soniaconnolly
Clean up ssn_controller_specs
6514d8c
@soniaconnolly
Add pii_from_doc to otp_verification_controller_spec
ebfb953
@solipet @soniaconnolly
add step_info to EnterPasswordController
fa2773d
@soniaconnolly
Bust the idv_session.profile cache when setting profile_id
059e4c4 
This is necessary to make a enter_password_controller_spec in person retry spec pass when touching
subject.idv_session. We suspect that when the code is running, it is using the cached profile, which
is fortunately identical to the newly-created retry profile.
@soniaconnolly
Use :confirm_step_allowed before action
5cd249d 
And stop stubbing idv_session and applicant in enter_password_controller_spec
solipet and others added 5 commits November 28, 2023 12:19
@soniaconnolly soniaconnolly force-pushed the doug-lg-11463-back-from-phone-step-cherrypicked branch from f5aea13 to fbf66f9 Compare November 28, 2023 20:31
matthinz
matthinz reviewed Nov 28, 2023
View reviewed changes
soniaconnolly and others added 11 commits November 28, 2023 13:07
@soniaconnolly
Add remote_document_capture_complete? for symmetry with ipp_document_…
6cacd04 
…capture_complete?
@soniaconnolly
Remove confirm_verify_info_step_complete from phone controller
f9afc53 
Superseded by confirm_step_allowed
Last use of method, so method removed
@soniaconnolly
remove confirm_verify_info_step_needed from how_to_verify and link_sent
a69150c 
This was the backstop for the previous back button PR, and is no longer needed
@soniaconnolly
Remove duplicate before action from request_letter controller
ab437a1 
And move confirm_step_allowed under rate limit before action to match other controllers
@soniaconnolly
Add clear_future_steps! everywhere
7d76a83 
Insurance for future changes even though there's nothing to clear now.
@soniaconnolly
Add specs around clear_future_steps and idv_session.applicant
0cc9b74 
In flow_policy_spec, test undo_future_steps_from_controller! starting from enter_password
and resubmitting ssn.
@solipet
Move the 'absolute path' for the controller name to StepInfo.full_con…
53845a7 
…troller_name

Add a spec for full_controller_name
@solipet
call invalidate_verify_info_step! in VerifyInfoController#update
0866126
@soniaconnolly
Remove unused confirm_address_step_complete method and specs
47bef7b
@soniaconnolly
Remove obsolete before_action from otp_verification_controller
900d152
@soniaconnolly
Remove unused Idv::Session#pii_from_user
ee0d617
soniaconnolly
soniaconnolly commented Nov 29, 2023
View reviewed changes
matthinz
matthinz reviewed Nov 29, 2023
View reviewed changes
@matthinz
Copy link
Contributor

matthinz commented Nov 29, 2023

This looks good to me, thank you @soniaconnolly and @solipet for your hard work here.

@soniaconnolly soniaconnolly merged commit 84b0e2e into main Nov 29, 2023
@soniaconnolly soniaconnolly deleted the doug-lg-11463-back-from-phone-step-cherrypicked branch November 29, 2023 23:40
@soniaconnolly soniaconnolly mentioned this pull request Nov 30, 2023
Merged
@mitchellhenke mitchellhenke mentioned this pull request Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@matthinz matthinz matthinz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@soniaconnolly @matthinz @solipet